linux-kernel - Re: [PATCH 4/4] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1001061044000.3630@localhost.localdomain>
Date:	Wed, 6 Jan 2010 10:45:20 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	uclinux-dev@...inux.org,
	Daisuke HATAYAMA <d.hatayama@...fujitsu.com>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH 4/4] elf_fdpic_core_dump(): fix build break in
 2.6.33-rc1



On Wed, 6 Jan 2010, David Howells wrote:
>
> From: Daisuke HATAYAMA <d.hatayama@...fujitsu.com>
> 
> Commit f6151dfea21496d43dbaba32cfcd9c9f404769bc causes ELF-FDPIC to break
> during building, so this patch fixes it together with a correction for the
> printk format.

The comment doesn't match the patch. There's no build breakage fix (the 
actual fix was already merged, and your patch reflects that), there's only 
a printk format "fix" that is actually a de-provement because it splits 
the string across multiple lines.

So a strong NAK to this patch.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/