linux-kernel - Re: [PATCH 2/2] NET: wireless, fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B44E10D.7090802@gmail.com>
Date:	Wed, 06 Jan 2010 20:14:21 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Gertjan van Wingerde <gwingerde@...il.com>
CC:	linville@...driver.com, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] NET: wireless, fix memory leak

On 01/06/2010 08:07 PM, Gertjan van Wingerde wrote:
> On 01/06/10 17:35, Jiri Slaby wrote:
>> @@ -717,6 +717,9 @@ int cfg80211_wext_siwscan(struct net_device *dev,
>>   out:
>>  	cfg80211_unlock_rdev(rdev);
>>  	return err;
>> +out_free:
>> +	kfree(creq);
>> +	goto out;
>>  }
>>  EXPORT_SYMBOL_GPL(cfg80211_wext_siwscan);
>>  
> 
> This last part looks a bit strange. Why don't you put out_free label before out label,

Because `out' is a part of non-error flow, where the creq should not be
freed.

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/