linux-kernel - Re: [PATCH 3/3] generic sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Jan 2010 19:16:12 +0000
From:	David Howells <dhowells@...hat.com>
To:	Christoph Hellwig <hch@....de>
Cc:	dhowells@...hat.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	linux@....linux.org.uk, starvik@...s.com, jesper.nilsson@...s.com,
	ysato@...rs.sourceforge.jp, takata@...ux-m32r.org,
	geert@...ux-m68k.org, zippel@...ux-m68k.org, gerg@...inux.org,
	ralf@...ux-mips.org, benh@...nel.crashing.org,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	lethal@...ux-sh.org, davem@...emloft.net, jdike@...toit.com,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	viro@...iv.linux.org.uk
Subject: Re: [PATCH 3/3] generic sys_ipc wrapper

Christoph Hellwig <hch@....de> wrote:

> various architectures have different strategies for the SHMAT version 1 case
> which apparently never gets used - at least on i386 it seems superflous as
> the compat code on x86-64 and ia64 doesn't even bother to implement it.

The SHMAT version 1 case can be dropped for FRV and MN10300 - neither of them
support iBCS.

> frv goes even further and uses unsigned long for all parameters execept for
> "ptr" which is a pointer type everywhere.  The change from int to unsigned
> long for "third" and back to "int" for the others on frv should be fine due
> to the in-register calling conventions for syscalls (we already had a
> similar issue with the generic sys_ptrace), but I'd prefer to have the arch
> maintainers looks over this in details.

That should be okay - the registers are all 32-bits, so int, long and pointers
are all the same size.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/