linux-kernel - Re: [PATCH] pxafb: fix regression from d2a34c13e7ccec5d06eafd60e6f80ea531b34668

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f17812d71001051618s1110b7d7l6377c1d0090fdbb9@mail.gmail.com>
Date:	Wed, 6 Jan 2010 08:18:43 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Martin Jansa <martin.jansa@...il.com>,
	linux-kernel@...r.kernel.org, Julia Lawall <julia@...u.dk>
Subject: Re: [PATCH] pxafb: fix regression from d2a34c13e7ccec5d06eafd60e6f80ea531b34668

>
> That patch fixes the build, but it also eliminates the test for
> fbi==NULL.  The changelog doesn't explain that change and I wonder if
> it was intentional and correct?
>
>

fbi has been well tested in pxafb_probe() and then passed to pxafb_smart_init()
and to pxafb_smart_update(), it's just unnecessary to test it again and again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/