linux-kernel - Re: [stable] [PATCH 83/97] ext4: Fix potential quota deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100106195514.GA22781@quack.suse.cz>
Date:	Wed, 6 Jan 2010 20:55:14 +0100
From:	Jan Kara <jack@...e.cz>
To:	Greg KH <greg@...ah.com>
Cc:	tytso@....edu, Greg KH <gregkh@...e.de>, Jan Kara <jack@...e.cz>,
	linux-kernel@...r.kernel.org, stable@...nel.org,
	stable-review@...nel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Dmitry Monakhov <dmonakhov@...nvz.org>
Subject: Re: [stable] [PATCH 83/97] ext4: Fix potential quota deadlock

On Wed 06-01-10 10:27:18, Greg KH wrote:
> On Wed, Jan 06, 2010 at 12:20:18AM -0500, tytso@....edu wrote:
> > On Tue, Jan 05, 2010 at 03:16:27PM -0800, Greg KH wrote:
> > > On Tue, Jan 05, 2010 at 10:39:27PM +0100, Jan Kara wrote:
> > > > On Tue 05-01-10 10:56:55, Greg KH wrote:
> > > > > On Tue, Jan 05, 2010 at 01:47:42AM +0100, Jan Kara wrote:
> > > > > > On Mon 04-01-10 16:33:36, Greg Kroah-Hartman wrote:
> > > > > > > From: Dmitry Monakhov <dmonakhov@...nvz.org>
> > > > > > > 
> > > > > > > commit d21cd8f163ac44b15c465aab7306db931c606908 upstream.
> > > > > >   Ted has found a serious bug in this patch over Christmas and fixed it.
> > > > > > Ted, do you prefer to just discard this patch or will you add your fixes?
> > > > > Do you have the git commit id of the patch that fixes it?
> > > >   Commits fixing the behavior are:
> > > > 0637c6f4135f592f094207c7c21e7c0fc5557834
> > > > ee5f4d9cdf32fd99172d11665c592a288c2b1ff4
> > > > 9d0be50230b333005635967f7ecd4897dbfd181b
> > > 
> > > Hm, should I add these as well, or back out all of the ext4 quota
> > > patches from .32 and .31?
> > 
> > I don't think you need to back out all of the ext4 quota patches; Jan
> > has looked at the more carefully than I (since they went in via the
> > quota tree instead of the ext4 tree) but as far as I know the d21cd8f1
> > is a standalone fix and the other patches shouldn't break if you just
> > drop patch #83.  Adding the above mentioned patches is definitely
> > necessary if you include Patch #83, though, since otherwise people
> > mounting uncoverted ext3 filesystems using ext4 will get the BUG in
> > fs/ext4/inode.c:1063 regression.
> > 
> > As far as whether it would be better to drop patch #83 or to include
> > these three commits, it's a bit of a toss up.  If you want to play it
> > safe, I'd say let's drop it for now and wait for week or so, so we can
> > make sure the people who are testing -rc3 are happy, and for the next
> > stable release we can pick it up plus the additional commits listed
> > above.
> 
> Ok, I've dropped this patch from both the .31 and .32 -stable queues,
> thanks.
  Thanks!

> Jan, want to resend this patch, along with the needed fixes, for the
> next round of -stable releases when you get a chance, to
> stable@...nel.org?
  OK, will do that if we don't spot new problems with them.

									Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/