lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 06 Jan 2010 12:57:56 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Kandukuri Vikram <vkandukuri@...eros.com>
Cc:	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	lrodriguez@...eros.com
Subject: Re: [PATCH] DFU Driver for Atheros bluetooth chipset AR3011

Hi Vikram,

> Signed-off-by: Vikram Kandukuri <vikram.kandukuri@...eros.com>
> Signed-off-by: Alicke Xu <sxu@...eros.com>
> Reviewed-by: Luis R. Rodriguez <lrodriguez@...eros.com>
> ---
>  drivers/bluetooth/Kconfig  |   13 +++-
>  drivers/bluetooth/Makefile |    1 +
>  drivers/bluetooth/ath3k.c  |  187 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 200 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/bluetooth/ath3k.c

patch has been applied to my trees.

However I still had to hand edit in various small ares. For example
BT_DBG doesn't require the \n newline. So you have never actually tested
the debug code. Otherwise you would have seen that something is off.
Also there were still a bunch of spaces in the code that I had to fix
manually.

Also I prefer if you a bit more consistent writing "Bluetooth" exactly
this way in comment and descriptions. It is brand name and the writing
is suppose to be consistent.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ