linux-kernel - Re: [Kgdb-bugreport] [PATCH 09/37] kgdb,blackfin: Add in kgdb_arch_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B451164.3010100@windriver.com>
Date:	Wed, 06 Jan 2010 16:40:36 -0600
From:	Jason Wessel <jason.wessel@...driver.com>
To:	Mike Frysinger <vapier.adi@...il.com>
CC:	Sonic Zhang <sonic.adi@...il.com>,
	"Zhang, Sonic" <Sonic.Zhang@...log.com>,
	kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	mingo@...e.hu
Subject: Re: [Kgdb-bugreport] [PATCH 09/37] kgdb,blackfin: Add in kgdb_arch_set_pc
 for blackfin

Mike Frysinger wrote:
> On Wed, Jan 6, 2010 at 15:34, Jason Wessel wrote:
>   
>> Mike Frysinger wrote:
>>     
>>> also, i see you added "notrace" to the Blackfin probe_kernel_write ...
>>> was that intentional ?  if so, this should probably go into
>>> include/linux/uaccess.h instead
>>>       
>> The notrace was just a cut and paste of the original in mm/maccess.c
>>     
>
> ah, i thought i checked mm/maccess.c, but i guess i looked at just
> probe_kernel_read().  the fact that this was missed under the Blackfin
> code is a good example for why notrace should be on prototypes, not
> function definitions :).  i'll send a sep patch for just this.
>   
Thanks for the input.  I made the changes you talked about and tested
the compilation on all the kgdb regression compiles.

I split the patch into 2 parts, 1 for the generic change, and 1 for the
blackfin cleanup.  Let me know if you approve and I can add acks from
you as well.

Thanks,
Jason.

View attachment "add__probe_kernel.patch" of type "text/x-diff" (2458 bytes)

View attachment "probe_kernel_blackfin.patch" of type "text/x-diff" (9058 bytes)