linux-kernel - Re: [PATCH 5/5] ACPI, APEI, Document for APEI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100107071254.GE1689@ucw.cz>
Date:	Thu, 7 Jan 2010 08:12:55 +0100
From:	Pavel Machek <pavel@....cz>
To:	Huang Ying <ying.huang@...el.com>
Cc:	"lenb@...nel.org" <lenb@...nel.org>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH 5/5] ACPI, APEI, Document for APEI

On Wed 2010-01-06 15:21:43, Huang Ying wrote:
> On Wed, 2010-01-06 at 15:16 +0800, Pavel Machek wrote:
> > > > +The user interface of EINJ is in debug file system, under the
> > > > +directory apei/einj. The following files are provided.
> > > > +
> > > > +- available_error_type
> > > > +  Read this file will return the error injection capability of the
> > > > +  platform, that is, which error types are supported. The error type
> > > > +  definition is as follow, the left field is the error type value, the
> > > > +  right field is error description.
> > > > +
> > > > +    0x00000001	Processor Correctable
> > > > +    0x00000002	Processor Uncorrectable non-fatal
> > > > +    0x00000004	Processor Uncorrectable fatal
> > > > +    0x00000008  Memory Correctable
> > > > +    0x00000010  Memory Uncorrectable non-fatal
> > > > +    0x00000020  Memory Uncorrectable fatal
> > > > +    0x00000040	PCI Express Correctable
> > > > +    0x00000080	PCI Express Uncorrectable fatal
> > > > +    0x00000100	PCI Express Uncorrectable non-fatal
> > > > +    0x00000200	Platform Correctable
> > > > +    0x00000400	Platform Uncorrectable non-fatal
> > > > +    0x00000800	Platform Uncorrectable fatal
> > > > +
> > > > +  The format of file contents are as above, except there are only the
> > > > +  available error type lines.
> > 
> > Strange interface. Why not simply pass single integer -- the bit mask?
> > Bit meanings are not going to change, anyway.
> 
> I have used bit mask in previous versions. But I think this version has
> better readability.

Better usability for humans, but kernel interfaces are not for
humans. Please revert to bit mask. 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/