lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Jan 2010 15:33:46 +0800 From: Eric Miao <eric.y.miao@...il.com> To: Pavel Machek <pavel@....cz> Cc: dtor@...l.ru, linux-input@...r.kernel.org, rpurdie@...ys.net, lenz@...wisc.edu, kernel list <linux-kernel@...r.kernel.org>, Dirk@...er-online.de, arminlitzel@....de, Cyril Hrubis <metan@....cz>, thommycheck@...il.com, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, dbaryshkov@...il.com, omegamoon@...il.com, utx@...guin.cz, zaurus-devel@...ts.linuxtogo.org, "Rafael J. Wysocki" <rjw@...k.pl>, Andrew Morton <akpm@...l.org> Subject: Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1 On Thu, Jan 7, 2010 at 2:52 PM, Pavel Machek <pavel@....cz> wrote: > On Wed 2010-01-06 15:17:39, Eric Miao wrote: >> On Wed, Jan 6, 2010 at 3:10 PM, Pavel Machek <pavel@....cz> wrote: >> > >> > Sharp-SL code uses strange, complex grouping of gpios for wakeups >> > toggling. Fortunately, it is unneeded in recent kernels (and actually >> > provokes WARN_ONs during resume). Remove it. >> > >> > Signed-off-by: Pavel Machek <pavel@....cz> >> >> Pavel, >> >> The code to be removed below is used to support pxa27x_keypad >> to be able to resume from sleep. What's the exact reason to remove >> this on spitz? > > Well, otherwise I get this during resume: (2.6.32 regression) > > (and similar for matrix-keypad, but dmitry worked around that > already). > > Problem is that gpio-keys and matrix-keypad want to set_wake for each > gpio individually, hw can do that, but pxa27x.c breaks it. > > I don't get it; what is pxa27x_keypad used on? It looks like > matrix-keypad subset. > pxa27x has its own specific keypad controller. And since we now use enable_irq_wake, and the keypad controller has only one such IRQ_KEYPAD, will have to setup the keypad GPIO wakeup as a whole. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists