[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100107.010201.51693251.davem@davemloft.net>
Date: Thu, 07 Jan 2010 01:02:01 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: mpm@...enic.com
Cc: danborkmann@...glemail.com, linux-kernel@...r.kernel.org,
jmoyer@...hat.com, netdev@...r.kernel.org, netdev@....sgi.com
Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per
interface
From: Matt Mackall <mpm@...enic.com>
Date: Wed, 06 Jan 2010 21:54:05 -0600
> Please inline patches so they can be reviewed easily in reply.
>
>
> - struct netpoll *np = npi->rx_np;
> + struct netpoll **np = &npi->rx_np;
>
> - if (!np)
> + if (!(*np))
>
> This makes everything horrible. Can you avoid the double indirection?
> Using a list head might be a good answer.
>
Agreed on all counts.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists