[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4B45C35E.4080506@suse.cz>
Date: Thu, 07 Jan 2010 12:19:58 +0100
From: Michal Marek <mmarek@...e.cz>
To: John Kacur <jkacur@...hat.com>
Cc: linux-kernel@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>,
linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] Don't mkdir -p include/config in the sourcetree when
using O=outputdir option
On 6.1.2010 23:30, John Kacur wrote:
> On Wed, Jan 6, 2010 at 9:45 PM, Michal Marek <mmarek@...e.cz> wrote:
> Michal: The length of time that a bug exists in a piece of code is no
> argument for
> it's correctness!
>From your original post I though it fails reliably for you. If it's a
race, then you're right, the time it was introduced is irrelevant :-).
> I tried to debug this using
> make -d V=1 O=/bld/2.6.33-rc3
> and discovered that the bug did not always occur, but did sometimes.
> This leads me to think that it is timing sensitive, and indeed the
> problem shows up
> more easily on a machine with multiple processors.
>
> Is it possible that the step with mkdir -p can sometimes occur in a
> Makefile parallel process
> before the cd KBUILD_OUTPUT occurs? That would explain why it doesn't
> reliably reproduce.
OK, I still don't see how it fails, but adding $(objtree) there is a
valid change and if it fixes your problem, let's apply it.
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists