linux-kernel - Re: [PATCH 1/1] FS: reiserfs, fix unreachable statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100107113341.GA5093@nowhere>
Date:	Thu, 7 Jan 2010 12:33:44 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	jirislaby@...il.com, reiserfs-devel@...r.kernel.org
Subject: Re: [PATCH 1/1] FS: reiserfs, fix unreachable statement

On Wed, Jan 06, 2010 at 11:09:50PM +0100, Jiri Slaby wrote:
> Stanse found an unreachable statement in reiserfs_ioctl. There is
> if followed by assignment and `break'. with no braces. Add the
> braces so that we don't break every time, but only in error case.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: reiserfs-devel@...r.kernel.org
> ---



Looks good.
I've applied it, thanks!



>  fs/reiserfs/ioctl.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/reiserfs/ioctl.c b/fs/reiserfs/ioctl.c
> index ace7745..f53505d 100644
> --- a/fs/reiserfs/ioctl.c
> +++ b/fs/reiserfs/ioctl.c
> @@ -104,9 +104,10 @@ setflags_out:
>  		err = put_user(inode->i_generation, (int __user *)arg);
>  		break;
>  	case REISERFS_IOC_SETVERSION:
> -		if (!is_owner_or_cap(inode))
> +		if (!is_owner_or_cap(inode)) {
>  			err = -EPERM;
>  			break;
> +		}
>  		err = mnt_want_write(filp->f_path.mnt);
>  		if (err)
>  			break;
> -- 
> 1.6.5.7
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/