[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100107101805.b26a1f1a.kamezawa.hiroyu@jp.fujitsu.com>
Date: Thu, 7 Jan 2010 10:18:05 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Cc: akpm@...ux-foundation.org, LKML <linux-kernel@...r.kernel.org>,
"Kirill A. Shutemov" <kirill@...temov.name>,
Balbir Singh <balbir@...ux.vnet.ibm.com>
Subject: Re: [PATCH -mmotm] memcg: implement memory thresholds document
fixes
On Thu, 7 Jan 2010 09:57:14 +0900
Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote:
> Each memcg-implement-memory-thresholds.patch and
> memcg-add-interface-to-move-charge-at-task-migration.patch try to add a new
> section to Documentation/cgroup/memory.txt, so the document has been a bit
> mangled when these patches are merged at the same time.
>
> This patch fixes it.
>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
BTW, I'll prepare total update for memcg (especially around percpu counter).
Do you have something may conflict in plan ?
Thanks,
-Kame
> Signed-off-by: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
> Cc: Kirill A. Shutemov <kirill@...temov.name>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Cc: Balbir Singh <balbir@...ux.vnet.ibm.com>
> ---
> This patch can be applied after memcg-implement-memory-thresholds-checkpatch-fixes.patch.
>
> Documentation/cgroups/memory.txt | 21 ++++++++++-----------
> 1 files changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt
> index 226a955..aad7d05 100644
> --- a/Documentation/cgroups/memory.txt
> +++ b/Documentation/cgroups/memory.txt
> @@ -458,7 +458,15 @@ Note: Those pages and swaps must be charged to the old cgroup.
> Note: More type of pages(e.g. file cache, shmem,) will be supported by other
> bits in future.
>
> -8.3 Memory thresholds
> +8.3 TODO
> +
> +- Add support for other types of pages(e.g. file cache, shmem, etc.).
> +- Implement madvise(2) to let users decide the vma to be moved or not to be
> + moved.
> +- All of moving charge operations are done under cgroup_mutex. It's not good
> + behavior to hold the mutex too long, so we may need some trick.
> +
> +9. Memory thresholds
>
> Memory controler implements memory thresholds using cgroups notification
> API (see cgroups.txt). It allows to register multiple memory and memsw
> @@ -475,16 +483,7 @@ threshold in any direction.
>
> It's applicable for root and non-root cgroup.
>
> -
> -8.4 TODO
> -
> -- Add support for other types of pages(e.g. file cache, shmem, etc.).
> -- Implement madvise(2) to let users decide the vma to be moved or not to be
> - moved.
> -- All of moving charge operations are done under cgroup_mutex. It's not good
> - behavior to hold the mutex too long, so we may need some trick.
> -
> -9. TODO
> +10. TODO
>
> 1. Add support for accounting huge pages (as a separate controller)
> 2. Make per-cgroup scanner reclaim not-shared pages first
> --
> 1.5.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists