lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20100107205838.GA23120@elf.ucw.cz>
Date:	Thu, 7 Jan 2010 21:58:38 +0100
From:	Pavel Machek <pavel@....cz>
To:	mark gross <mgross@...ux.intel.com>
Cc:	640E9920 <640e9920@...il.com>, linux-pm@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [linux-pm] [RFC] PM_QOS api update to use handles 1/5

On Thu 2010-01-07 12:55:58, mark gross wrote:
> On Wed, Jan 06, 2010 at 08:18:31PM +0100, Pavel Machek wrote:
> > Hi!
> > 
> > > > Umm.. passing binary numbers like that... is not exactly good
> > > > interface. Think endianness issues  when writing to it from high-level
> > > > language.
> > > 
> > > yeah.  At the moment I can't recall why I went binary for the ABI, 
> > > we can revisit this, but its been in the wild for a few years now :(
> > > 
> > > I guess I can do some tricks to see if its a hex string representation
> > > of a number and parse that as well as supporting the s32.  i.e. accept
> > > strings "0x0000000" ... "0xFFFFFFFF" and return -EINVAL for anything
> > > else.
> > 
> > Maybe you could use length for detection? If they are writing 4 bytes,
> > it is s32, 10 bytes means ascii?
> 
> That is what I was thinking + making sure the chars in the string where
> valid hex digits ;)  It would be easy to do.  Let me know if you think I
> should attempt to roll that into the kernel ABI exposed by this thing.

I think that would be nice, yes.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ