linux-kernel - RE: [PATCH] KVM: dereference of NULL pointer in set_pal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Jan 2010 07:28:57 +0800
From:	"Zhang, Xiantao" <xiantao.zhang@...el.com>
To:	Roel Kluin <roel.kluin@...il.com>,
	"kvm-ia64@...r.kernel.org" <kvm-ia64@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] KVM: dereference of NULL pointer in set_pal_result()

For the check "(p && p->exit_reason == EXIT_REASON_PAL_CALL", if p is NULL, the reference about "p->exit_reason == EXIT_REASON_PAL_CALL" won't be checked any more, so no issue here. 
Xiantao


Roel Kluin wrote:
> Do not dereference a NULL pointer
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
>  arch/ia64/kvm/kvm_fw.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/ia64/kvm/kvm_fw.c b/arch/ia64/kvm/kvm_fw.c
> index e4b8231..d28494f 100644
> --- a/arch/ia64/kvm/kvm_fw.c
> +++ b/arch/ia64/kvm/kvm_fw.c
> @@ -75,9 +75,11 @@ static void set_pal_result(struct kvm_vcpu *vcpu,
>  	struct exit_ctl_data *p;
> 
>  	p = kvm_get_exit_data(vcpu);
> -	if (p && p->exit_reason == EXIT_REASON_PAL_CALL) {
> +	if (!p)
> +		return;
> +	if (p->exit_reason == EXIT_REASON_PAL_CALL) {
>  		p->u.pal_data.ret = result;
> -		return ;
> +		return;
>  	}
>  	INIT_PAL_STATUS_UNIMPLEMENTED(p->u.pal_data.ret);
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/