linux-kernel - RE: [PATCH] mtd/nand: Fix build failure caused by typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jan 2010 21:16:35 -0500
From:	"H Hartley Sweeten" <hartleys@...ionengravers.com>
To:	Peter Hüwe <PeterHuewe@....de>,
	"David Woodhouse" <dwmw2@...radead.org>
Cc:	"Nicolas Pitre" <nico@...vell.com>,
	Uwe  Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	<linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mtd/nand: Fix build failure caused by typo

On Wednesday, January 06, 2010 7:02 PM, Peter Hüwe wrote:
> From: Peter Huewe <peterhuewe@....de>
> Date: Thu, 7 Jan 2010 02:51:13 +0100
> 
> This patch fixes a build failure[1] introduced by the patch
>     mtd: orion_nand.c: add error handling and use resource_size()
>     by H Hartley Sweeten [2]
> The patch assigns something to a undeclared variable 'err', whereas the
> rest of the code uses 'ret' for this task.
> 
> This patch fixes this typo and thus removes the build failure.
> 
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/1983354/
> [2] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=e99030609e27abff7e1a868cb56384c678b09984
> 
> Patch against linux-next of Do 7. Jan 02:58:41 CET 2010
> 
> Signed-off-by: Peter Huewe <peterhuewe@....de>
> ---
>  drivers/mtd/nand/orion_nand.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
> index 9903460..f16050c 100644
> --- a/drivers/mtd/nand/orion_nand.c
> +++ b/drivers/mtd/nand/orion_nand.c
> @@ -92,7 +92,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!res) {
> -		err = -ENODEV;
> +		ret = -ENODEV;
>  		goto no_res;
>  	}

Sorry about that.

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/