linux-kernel - Re: [PATCH 1/2] perf: add close()/closedir() calls when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B467433.3060701@zytor.com>
Date:	Thu, 07 Jan 2010 15:54:27 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Alexander Beregalov <a.beregalov@...il.com>
CC:	Paul Mackerras <paulus@...ba.org>, a.p.zijlstra@...llo.nl,
	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] perf: add close()/closedir() calls when needed

On 01/07/2010 02:44 PM, Alexander Beregalov wrote:
> 2010/1/8 Paul Mackerras <paulus@...ba.org>:
>> On Thu, Jan 07, 2010 at 07:40:46PM +0300, Alexander Beregalov wrote:
>>
>>> Close file and directory descriptors before exiting or dying.
>>
>> Your patch description doesn't say why that's a good thing to do, and
>> it's not obvious to me at least.  Please explain the motivation in
>> your patch description.
> 
> Isn't it a good style to close files after use and before exit?

exit() closes all files, so it's redundant.

It's "good style" in the sense that it can help librarization, though.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/