linux-kernel - Re: mmotm 2010-01-06-14-34 uploaded (kernel/cgroup)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B4549CB.8000809@cn.fujitsu.com>
Date:	Thu, 07 Jan 2010 10:41:15 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
CC:	Randy Dunlap <randy.dunlap@...cle.com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	"menage@...gle.com" <menage@...gle.com>, kirill@...temov.name
Subject: Re: mmotm 2010-01-06-14-34 uploaded (kernel/cgroup)

KAMEZAWA Hiroyuki wrote:
> On Wed, 6 Jan 2010 17:08:49 -0800
> Randy Dunlap <randy.dunlap@...cle.com> wrote:
> 
>> On Wed, 06 Jan 2010 14:34:36 -0800 akpm@...ux-foundation.org wrote:
>>
>>> The mm-of-the-moment snapshot 2010-01-06-14-34 has been uploaded to
>>>
>>>    http://userweb.kernel.org/~akpm/mmotm/
>>>
>>> and will soon be available at
>>>
>>>    git://zen-kernel.org/kernel/mmotm.git
>>>
>>> It contains the following patches against 2.6.33-rc3:
>>
>> kernel/cgroup.c: In function 'cgroup_write_event_control':
>> kernel/cgroup.c:2949: error: implicit declaration of function 'eventfd_fget'
>> kernel/cgroup.c:2949: warning: assignment makes pointer from integer without a cast
>> kernel/cgroup.c:2955: error: implicit declaration of function 'eventfd_ctx_fileget'
>> kernel/cgroup.c:2955: warning: assignment makes pointer from integer without a cast
>> make[2]: *** [kernel/cgroup.o] Error 1
>>
> 
> Hmm, how about this rather than adding #ifdefs..
> Paul, Li, how do you think ?

I think make CONFIG_CGROUPS select EVENTFD would be better.

> ==
> Cgroup's eventdf feature has depenedecy to EVENTFD
> 
> This is a patch onto
> cgroup-implement-eventfd-based-generic-api-for-notifications.patch
> 
> CC: Li Zefan <lizf@...fujitsu.com>
> CC: Kirill A. Shutemov <kirill@...temov.name>
> CC: Paul Menage <menage@...gle.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> 
> ---
>  init/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: ref-mmotm/init/Kconfig
> ===================================================================
> --- ref-mmotm.orig/init/Kconfig
> +++ ref-mmotm/init/Kconfig
> @@ -509,6 +509,7 @@ endchoice
>  
>  menuconfig CGROUPS
>  	boolean "Control Group support"
> +	depends on EVENTFD
>  	help
>  	  This option adds support for grouping sets of processes together, for
>  	  use with process control subsystems such as Cpusets, CFS, memory
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/