linux-kernel - Re: mmotm 2010-01-06-14-34 uploaded (mm/memcontrol)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100107120233.f244d4b7.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Thu, 7 Jan 2010 12:02:33 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: mmotm 2010-01-06-14-34 uploaded (mm/memcontrol)

On Thu, 7 Jan 2010 11:59:01 +0900
Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote:

> Thank you for your fix.
> 
> On Thu, 7 Jan 2010 11:21:50 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:
> > On Thu, 7 Jan 2010 11:13:19 +0900
> > Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote:
> > 
> > > Thank you for your report.
> >  
> > > > config attached.
> > > > 
> > > I'm sorry I missed the !CONFIG_SWAP or !CONFIG_CGROUP_MEM_RES_CTLR_SWAP case.
> > > 
> > > I'll prepare fixes.
> > > 
> > Nishimura-san, could you double check this ?
> > 
> It seems that this cannot fix the !CONFIG_SWAP case in my environment.
> 
> > Andrew, this is a fix onto Nishimura-san's memcg move account patch series.
> > Maybe this -> patches/memcg-move-charges-of-anonymous-swap.patch
> > 
> I think both memcg-move-charges-of-anonymous-swap.patch and
> memcg-improve-performance-in-moving-swap-charge.patch need to be fixed.
> 
> > mm/memcontrol.c: In function 'is_target_pte_for_mc':
> > mm/memcontrol.c:3985: error: implicit declaration of function 'mem_cgroup_count_swap_user'
> This derives from a bug of memcg-move-charges-of-anonymous-swap.patch,
> 
> and
> 
> > mm/memcontrol.c: In function 'mem_cgroup_move_charge_pte_range':
> > mm/memcontrol.c:4220: error: too many arguments to function 'mem_cgroup_move_swap_account'
> > mm/memcontrol.c:4220: error: too many arguments to function 'mem_cgroup_move_swap_account'
> > mm/memcontrol.c:4220: error: too many arguments to function 'mem_cgroup_move_swap_account'
> this derives from that of memcg-improve-performance-in-moving-swap-charge.patch.
> 
> 
> I'm now testing my patch in some configs, and will post later.
> 
Okay, plz.

Thanks,
-Kame



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/