linux-kernel - Re: [PATCH] gpio: introduce gpio_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f17812d71001072316j54514eb4mf7ff2df619515874@mail.gmail.com>
Date:	Fri, 8 Jan 2010 15:16:00 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Ben Nizette <bn@...sdigital.com>
Cc:	David Brownell <david-b@...bell.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] gpio: introduce gpio_request_one() and friends

On Fri, Jan 8, 2010 at 2:08 PM, Ben Nizette <bn@...sdigital.com> wrote:
>
> On 08/01/2010, at 4:14 PM, Eric Miao wrote:
>
>> commit 29cd35f57699fd93a12132186d52109a55ed57e7
>> Author: Eric Miao <eric.y.miao@...il.com>
>> Date:   Fri Jan 8 12:16:28 2010 +0800
>>
>>    gpio: introduce gpio_request_one() and friends
>>
>>    gpio_request() without initial configuration of the GPIO is normally
>>    useless, introduce gpio_request_one() together with GPIOF_ flags for
>>    input/output direction and initial output level.
>
> Well yea it is useless without initial configuration but I've always done that configuration before any gpiolib calls.  The initial direction and state stuff really has to be set up and pin-mux or gpio-chip-activate time otherwise it'll glitch; by the time we get to gpio_request time I've got everything just how I like it and just want the refcount aspect of gpio_request.
>

The hardware will anyway glitch if the pin mux and GPIO registers are
different, which is almost true on every platform. The problem is not
to prevent GPIO from being glitch, but how to survive GPIO glitch.

1. from HW, in some cases the reset state of GPIOs are input, which
is basically high-z from the outside, so is not likely to cause problems.

2. if the GPIO reset state is output, with a fixed level (either high or low),
yet the software initializes it to be the opposite, then glitch happens, and
this will impact the external. In such cases, software needs to make sure
there will be no negative impact, e.g. put the external impact chip into
reset or power off state until GPIOs connected are configured to known state.

> I'm obviously thinking in a very small-minded platform-gpio-only kind of a way, what system have you got which uses this (and how does it not glitch)?
>

Mostly PXA processor based systems and they do glitch with careless
configuration and hw design. The patch here is not going to solve the
glitch problem, but to group the request and configuration together as
most GPIO API users are using these two together, and some are using
gpio_request + gpio_direction_* again and again repeatedly for a bunch
of GPIOs, which is not clean.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/