linux-kernel - RE: [PATCH 1/2] i2c: Add support for Ux500/Nomadik I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Jan 2010 02:39:02 +0530
From:	srinidhi kasagar <srinidhi.kasagar@...ricsson.com>
To:	Linus WALLEIJ <linus.walleij@...ricsson.com>
Cc:	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"ben-linux@...ff.org" <ben-linux@...ff.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	STEricsson_nomadik_linux <STEricsson_nomadik_linux@...t.st.com>,
	Sachin VERMA <sachin.verma@...com>,
	Andrea GALLO <andrea.gallo@...ricsson.com>, <rubini@...pv.it>
Subject: RE: [PATCH 1/2] i2c: Add support for Ux500/Nomadik I2C controller

On Thu, 2010-01-07 at 21:37 +0100, Linus WALLEIJ wrote:
> > +++ b/drivers/i2c/busses/i2c-nmk.c
> (...)
> > +	dev->irq = platform_get_irq(pdev, 0);
> > +	ret = request_irq(dev->irq, i2c_irq_handler, IRQF_DISABLED,
> > +				DRIVER_NAME, dev);
> 
> Since I2C IRQs can be a bit tedious, could this be converted
> to a request_threaded_irq()? OK I know that is probably a bit
> intrusive and can very well be done later (so no blocker) but
> think about it.

hmm..I tried using request_threaded_irq, but seems not to be working at
the first step, did not debug further. So, I will post v2 patch fixing
the rest of your comments. Once I have this driver working fully with
threaded implementation, I will post a patch on top of it. Hope this is
OK.

Srinidhi 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/