linux-kernel - Re: [PATCH] Convert the AB3100 driver to use threaded IRH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63386a3d1001080209q51cf62f8tfbe7c2062e1657f3@mail.gmail.com>
Date:	Fri, 8 Jan 2010 11:09:31 +0100
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Convert the AB3100 driver to use threaded IRH

2010/1/8 Samuel Ortiz <sameo@...ux.intel.com>:

> Linus, I fogot to mention that I removed IRQF_SAMPLE_RANDOM from your
> request_threaded_irq() arguments, as it is scheduled for removal. See
> Documentation/feature-removal-schedule.txt.
> Please let me know if that's a problem for you.

I got the warning from checkpatch as well, and since this is an
interrupt source which is truly random and we really *want* to sample
for some IRQ randomness I do want that functionality in there.

However the fucntions to be used instead,
rand_initialize_irq() + add_interrupt_randomness() aren't used
anywhere else in the kernel than in the interrupt driver core.

But I don't mind being first ... if you upload your git tree to
git.kernel.org I'll make a patch to reenable this the right way.
(Or I can rewrite the previous patch, your choice.)

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/