linux-kernel - Re: [PATCH] quota: fix reserved space management for ordinary fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1001081133180.1461@er-systems.de>
Date:	Fri, 8 Jan 2010 12:03:07 +0100 (CET)
From:	Thomas Voegtle <tv@...96.de>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
cc:	Dmitry Monakhov <rjevskiy@...il.com>, Greg KH <gregkh@...e.de>,
	Jan Kara <jack@...e.cz>, Theodore Ts'o <tytso@....edu>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, stable@...nel.org
Subject: Re: [PATCH] quota: fix reserved space management for ordinary fs

On Fri, 8 Jan 2010, Dmitry Monakhov wrote:

>
> In fact inode_get_rsv_space() function is special in comparison
> with inode_{add,sub,claim}_rsv_space() functions, because
> it may return correct result even for fs without reserved space
> support(correct val == 0). Add trivial check for that case.
> The patch fix regression(BUG at fs/quota/dquot.c:1350) introduced
> in following commit: fd8fbfc1709822bd94247c5b2ab15a5f5041e103
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
> ---
> fs/quota/dquot.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index dea86ab..d9f06cf 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -1377,6 +1377,8 @@ static void inode_sub_rsv_space(struct inode *inode, qsize_t number)
> static qsize_t inode_get_rsv_space(struct inode *inode)
> {
> 	qsize_t ret;
> +	if (!inode->i_sb->dq_op->get_reserved_space)
> +		return 0;
> 	spin_lock(&inode->i_lock);
> 	ret = *inode_reserved_space(inode);
> 	spin_unlock(&inode->i_lock);
>

Patch works for me on top of 2.6.33-rc3 and on top of 2.6.31.11.

Thanks,

Thomas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/