linux-kernel - Re: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201001081230.14419.eike-kernel@sf-tec.de>
Date:	Fri, 8 Jan 2010 12:30:13 +0100
From:	Rolf Eike Beer <eike-kernel@...tec.de>
To:	René Bolldorf <xsecute@...glemail.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"linux-scsi" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset()

René Bolldorf wrote:
> On 01/07/10 21:34, René Bolldorf wrote:
> > On 01/07/10 20:15, Jeff Garzik wrote:
> >> I need a little bit more detail than an unqualified statement... Did
> >> you audit all paths leading to this code point?
> >
> > Yes, and my two systems running fine with the patch, no oops or panic's.
> 
> Sry forgot that:
> 	/* initialize sense_buf with the error register,
> 	 * for the case where they are -not- overwritten
> 	 */
> 	sense_buf[0] = 0x70;
> 	sense_buf[2] = dfl_sense_key;
> 
> So i think memset() is not needed and works very well without it.

What happens to sense_buf[1]?

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)