linux-kernel - Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B473F64.2010203@debian.org>
Date:	Fri, 08 Jan 2010 15:21:24 +0100
From:	"Giacomo A. Catenazzi" <cate@...ian.org>
To:	"Rick L. Vinyard, Jr." <rvinyard@...nmsu.edu>
CC:	Jaya Kumar <jayakumar.lkml@...il.com>,
	linux-kernel@...r.kernel.org, krzysztof.h1@...pl,
	akpm@...ux-foundation.org, linux-usb@...r.kernel.org,
	oliver@...kum.org, linux-input@...r.kernel.org, jkosina@...e.cz,
	linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

Sorry to enter in this discussion so late.

What about g15 keyboards and related keyboards?

It would nice if your driver could handle also the other keyboards.

The package g15daemon handles such keyboards (or LCD screens):

# Logitech g11 -- extra keys, no LCD
# Logitech G15 (blue) -- extra keys and LCD
# Logitech G15 v2 (orange) -- extra keys and LCD
# Logitech Z10 -- extra keys and LCD, shared with audio, not a keyboard
# Logitech G15 Gamepanel -- extra keys and LCD

but using an daemon has it own problems, so I would like to
move the support to the kernel.

Is it ok for you?

Could you use a more generic name for configuration?
(e.g. CONFIG_LOGITECH_G_SERIES)

ciao
	cate


On 07.01.2010 16:59, Rick L. Vinyard, Jr. wrote:
> Jaya Kumar wrote:
>> On Tue, Dec 15, 2009 at 5:22 AM, Rick L. Vinyard Jr.
>> <rvinyard@...nmsu.edu>  wrote:
>>> Additionally, this device contains a 160x43 monochrome LCD display.
>>> A registered framebuffer device manages this display. The design
>>> of this portion of the driver was based on the design of the
>>> hecubafb driver with deferred framebuffer I/O since there is
>>> no real memory to map.
>>
>> Hi Rick,
>>
>> Interesting work. I recommend CCing linux-fbdev@...r.kernel.org too
>> since it contains a fbdev interface.
>>
>
> Thanks. Added.
>
>>> +config LOGITECH_G13
>>> +       tristate "Logitech G13 gameboard support"
>>> +       depends on HID_LOGITECH
>>> +       depends on FB
>>> +       select FB_SYS_FILLRECT
>>> +       select FB_SYS_COPYAREA
>>> +       select FB_SYS_IMAGEBLIT
>>> +       select FB_SYS_FOPS
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/