linux-kernel - Re: [PATCH v3 3/3] generic sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201001081649.34308.arnd@arndb.de>
Date:	Fri, 8 Jan 2010 16:49:34 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Christoph Hellwig <hch@....de>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, linux@....linux.org.uk,
	starvik@...s.com, jesper.nilsson@...s.com, dhowells@...hat.com,
	ysato@...rs.sourceforge.jp, takata@...ux-m32r.org,
	geert@...ux-m68k.org, zippel@...ux-m68k.org, gerg@...inux.org,
	ralf@...ux-mips.org, benh@...nel.crashing.org,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	lethal@...ux-sh.org, davem@...emloft.net, jdike@...toit.com,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	viro@...iv.linux.org.uk
Subject: Re: [PATCH v3 3/3] generic sys_ipc wrapper

On Friday 08 January 2010, Christoph Hellwig wrote:
> Possiblly.  Not sure if it's worth it, though.  If the s390 maintainers
> want it I'd say do it as a separate patch.

Sounds fair.

> at least on powerpc and s390, possibly on all 64 bit machines:
> 
> > > +                   return -EINVAL;
> > > +           if (get_user(fourth.__pad, (void __user * __user *) ptr))
> > > +                   return -EFAULT;
> > > +           return sys_semctl(first, second, third, fourth);
> > 
> >               return sys_semctl(first, (int)second, third, fourth);
> 
> What does the explicit case buy us in terms of sign-extension over
> the implicit one given that the second argument to sys_semctl already is
> types as int?

You're right, it's not needed any more, in particular since Heiko
added the wrappers around each syscall to do yet another sign extension,
but this one was probably right in your version already.

You convinced me that the patch is good in its current shape.

Acked-by: Arnd Bergmann <arnd@...db.de>

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/