linux-kernel - Re: [PATCH] Makefile: do not override LC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Jan 2010 10:50:17 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Michal Marek <mmarek@...e.cz>
CC:	Simon Horman <horms@...ge.net.au>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Roland Dreier <rdreier@...co.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Sergei Trofimovich <slyfox@...ox.ru>,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH] Makefile: do not override LC_CTYPE

On 01/08/2010 04:16 AM, Michal Marek wrote:
> Setting LC_CTYPE=C breaks localized messages in some setups. With only
> LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not
> so defined character classes and tolower()/toupper(). The former is not
> a big issue, because we can assume that e.g. [:alpha:] will always
> include a-zA-Z and we only ever process ASCII input. The latter seems
> only affect arch/sh/tools/gen-mach-types, which we can handle separately.
> 
> So after this patch the meaning of ranges like [a-z], the behavior of
> sort and join, etc. should be the same everywhere and at the same time
> gcc should be able to print localized waring and error messages.
> LC_NUMERIC=C might not be necessary, but setting it doesn't hurt.
> 
> Reported-by: Simon Horman <horms@...ge.net.au>
> Reported-by: Sergei Trofimovich <slyfox@...ox.ru>
> Signed-off-by: Michal Marek <mmarek@...e.cz>

For what it's worth:

Acked-by: H. Peter Anvin <hpa@...or.com>

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/