linux-kernel - checkpatch: EXPORT_SYMBOL() false positive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1001082021230.7591@ayla.of.borg>
Date:	Fri, 8 Jan 2010 20:23:50 +0100 (CET)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Andy Whitcroft <apw@...onical.com>
cc:	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Finn Thain <fthain@...egraphics.com.au>
Subject: checkpatch: EXPORT_SYMBOL() false positive

	Hi Andy,

A patch from Finn causes a false positive in checkpatch:

| WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
| #13: FILE: arch/m68k/mac/config.c:801:
| +EXPORT_SYMBOL(scc_a_pdev);

Test case from the patch:

--- a/arch/m68k/mac/config.c
+++ b/arch/m68k/mac/config.c
@@ -792,6 +792,32 @@ static struct mac_model mac_data_table[] = {
 	}
 };
 
+struct platform_device scc_a_pdev = {
+	.name           = "scc",
+	.id             = 0,
+	.num_resources  = ARRAY_SIZE(scc_a_rsrcs),
+	.resource       = scc_a_rsrcs,
+};
+EXPORT_SYMBOL(scc_a_pdev);
+
 static void __init mac_identify(void)
 {

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/