linux-kernel - Re: [PATCH 1/3] staging: make PCI device id constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100109234304.GA6168@suse.de>
Date:	Sat, 9 Jan 2010 15:43:05 -0800
From:	Greg KH <gregkh@...e.de>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Németh Márton <nm127@...email.hu>,
	devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>,
	Julia Lawall <julia@...u.dk>, cocci@...u.dk
Subject: Re: [PATCH 1/3] staging: make PCI device id constant

On Sat, Jan 09, 2010 at 03:41:15PM -0800, Arjan van de Ven wrote:
> On Sun, 10 Jan 2010 00:18:26 +0100
> Németh Márton <nm127@...email.hu> wrote:
> 
> > From: Márton Németh <nm127@...email.hu>
> > 
> > The id_table field of the struct pci_driver is constant in
> > <linux/pci.h> so it is worth to make the initialization data also
> > constant.
> 
> 
> the PCI ID table can get written too via sysfs... making it const
> breaks that...

It shouldn't, I thought that was what we used the dynids field in the
pci_driver structure :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/