linux-kernel - Re: [PATCH] af_packet: Don't use skb after dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100109122830.GA4386@del.dom.local>
Date:	Sat, 9 Jan 2010 13:28:30 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Michael Breuer <mbreuer@...jas.com>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	David Miller <davem@...emloft.net>, akpm@...ux-foundation.org,
	flyboy@...il.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()

On Fri, Jan 08, 2010 at 11:45:35PM -0500, Michael Breuer wrote:
> On 1/8/2010 4:48 PM, Michael Breuer wrote:
> >On 1/8/2010 4:29 PM, Jarek Poplawski wrote:
> >...
> >>BTW, don't hurry with that yet, but in the next test, please try
> >>alternative 2 again (i.e. with MMAP + no DMAR + disable_msi).
> >>
> >Will do - still up from yesterday... no more dropped packets...
> >none of the dns errors either. To be expected I suppose as long as
> >I'm trying to sniff it. Assuming no immediate erorrs with alt2, no
> >DMAR + disable_msi I'll report back after it's been up for a
> >while.
> >-- 
> Ok - ran alt1 and alt2, both with MMAP, no DMAR and disable_msi.
> Both seem to behave similarly. No logged errors;

Ok - since alt2 introduces less changes and is acked by Stephen
already, I'll resend it with your "Tested-by" in a new thread to clear
things a bit.

> large numbers of dropped RX packets.

You might try some tweaking with another sky2 parameter "copybreak"
or even editing its "NAPI_WEIGHT" variable.

> One odd thing: when driving every sort of
> traffic through, I was able to hose the client adapter (win7)
> repeatedly by runnnig the win7 backup and connecting Windows Media
> Player to a Mediatomb stream while also running a remote X11
> session. Looks like the SSDP traffic that occurs at the same time as
> the SMB traffic and X11 traffic takes out the adapter on Win7 -
> Nforce.
> Reran with msi enabled, MMAP and no DMAR. Also no errors; much
> faster, and the Win7 side survives the same conditions that don't
> work when msi is disabled. Doesn't make sense to me, but it is what
> it is.
> 
> Going to leave this up for a while and see if things remain functional.

It looks like DMAR is the main candidate for a new linux-kernel@ or
bugzilla bug report. You should also consider reporting these ipv6
problems, especially if you think they can trigger TX timeouts. (In
both cases it would be good to try current mainline first, when you
get it workable.)

Thanks,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/