linux-kernel - Re: [PATCH v4l/dvb] firedtv: add forgotten _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B49EE5E.9040904@s5r6.in-berlin.de>
Date:	Sun, 10 Jan 2010 16:12:30 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux-media@...r.kernel.org
CC:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4l/dvb] firedtv: add forgotten __exit annotation

Stefan Richter wrote on 2009-12-26:
> fdtv_fw_exit() is part of the firedtv driver's .exit.text section.
...
> --- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c
> +++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
> @@ -332,7 +332,7 @@ int __init fdtv_fw_init(void)
>  	return driver_register(&fdtv_driver.driver);
>  }
>  
> -void fdtv_fw_exit(void)
> +void __exit fdtv_fw_exit(void)
>  {
>  	driver_unregister(&fdtv_driver.driver);
>  	fw_core_remove_address_handler(&fcp_handler);
> 

This patch is bogus.  fdtv_fw_exit() is also called from firedtv's init.
-- 
Stefan Richter
-=====-==-=- ---= -=-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/