linux-kernel - Re: [PATCH] i2c-ali1563: remove sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 10 Jan 2010 16:45:08 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Németh Márton <nm127@...email.hu>
Cc:	Ben Dooks <ben-linux@...ff.org>, linux-i2c@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Julia Lawall <julia@...u.dk>, cocci@...u.dk
Subject: Re: [PATCH] i2c-ali1563: remove sparse warnings

On Sun, 10 Jan 2010 15:33:23 +0100, Németh Márton wrote:
> From: Márton Németh <nm127@...email.hu>
> 
> Remove the following sparse warnings (see "make C=1"):
>  * drivers/i2c/busses/i2c-ali1563.c:91:3: warning: do-while statement is not a compound statement
>  * drivers/i2c/busses/i2c-ali1563.c:161:3: warning: do-while statement is not a compound statement
> 
> Signed-off-by: Márton Németh <nm127@...email.hu>
> ---
> --- linux/drivers/i2c/busses/i2c-ali1563.c.orig	2010-01-10 13:40:31.000000000 +0100
> +++ linux/drivers/i2c/busses/i2c-ali1563.c	2010-01-10 13:54:16.000000000 +0100
> @@ -87,9 +87,9 @@
>  	outb_p(inb_p(SMB_HST_CNTL2) | HST_CNTL2_START, SMB_HST_CNTL2);
> 
>  	timeout = ALI1563_MAX_TIMEOUT;
> -	do
> +	do {
>  		msleep(1);
> -	while (((data = inb_p(SMB_HST_STS)) & HST_STS_BUSY) && --timeout);
> +	} while (((data = inb_p(SMB_HST_STS)) & HST_STS_BUSY) && --timeout);
> 
>  	dev_dbg(&a->dev, "Transaction (post): STS=%02x, CNTL1=%02x, "
>  		"CNTL2=%02x, CMD=%02x, ADD=%02x, DAT0=%02x, DAT1=%02x\n",
> @@ -157,9 +157,9 @@
>  	outb_p(inb_p(SMB_HST_CNTL2) | HST_CNTL2_START, SMB_HST_CNTL2);
> 
>  	timeout = ALI1563_MAX_TIMEOUT;
> -	do
> +	do {
>  		msleep(1);
> -	while (!((data = inb_p(SMB_HST_STS)) & HST_STS_DONE) && --timeout);
> +	} while (!((data = inb_p(SMB_HST_STS)) & HST_STS_DONE) && --timeout);
> 
>  	dev_dbg(&a->dev, "Block (post): STS=%02x, CNTL1=%02x, "
>  		"CNTL2=%02x, CMD=%02x, ADD=%02x, DAT0=%02x, DAT1=%02x\n",

Applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/