lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 10 Jan 2010 16:12:55 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	jdike@...toit.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uml: fix memory leak in arch/um/os-Linux/mem.c

On Sat, Jan 09, 2010 at 08:26:24PM +0300, Alexander Beregalov wrote:
>Free tempname before exit.
>Found by cppcheck.
>
>Signed-off-by: Alexander Beregalov <a.beregalov@...il.com>

Acked-by: WANG Cong <xiyou.wangcong@...il.com>

Thanks!

>---
> arch/um/os-Linux/mem.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c
>index 93a11d7..f079ea0 100644
>--- a/arch/um/os-Linux/mem.c
>+++ b/arch/um/os-Linux/mem.c
>@@ -175,7 +175,7 @@ static int __init make_tempfile(const char *template, char **out_tempname,
> 
> 	find_tempdir();
> 	if ((tempdir == NULL) || (strlen(tempdir) >= MAXPATHLEN))
>-		return -1;
>+		goto out;
> 
> 	if (template[0] != '/')
> 		strcpy(tempname, tempdir);
>-- 
>1.6.6
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists