linux-kernel - Re: [patch] hp-wmi: fix double free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b2b86521001100238x5c373f7x856a255e940baa5d@mail.gmail.com>
Date:	Sun, 10 Jan 2010 10:38:37 +0000
From:	Alan Jenkins <sourcejedi.lkml@...glemail.com>
To:	Dan Carpenter <error27@...il.com>, linux-kernel@...r.kernel.org
Cc:	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [patch] hp-wmi: fix double free

On 1/10/10, Dan Carpenter <error27@...il.com> wrote:
> kfree(obj) was called earlier.
>
> This was found by smatch and has only been compile tested.  :/

I don't see hp-wmi in MAINTAINERS, but in general platform drivers go
via the ACPI tree.

It looks like several others have discovered this issue the hard way
:-).  <http://www.pubbs.net/kernel/201001/14288/>.

Fortunately it has been fixed in the acpi tree and now submitted to
Linus.  <http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-01/msg02511.html>.

Regards
Alan

> --- orig/drivers/platform/x86/hp-wmi.c	2010-01-09 21:43:13.000000000 +0300
> +++ devel/drivers/platform/x86/hp-wmi.c	2010-01-09 21:43:28.000000000 +0300
> @@ -388,8 +388,6 @@ static void hp_wmi_notify(u32 value, voi
>  	} else
>  		printk(KERN_INFO "HP WMI: Unknown key pressed - %x\n",
>  			eventcode);
> -
> -	kfree(obj);
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/