linux-kernel - Re: linux-next: mfd tree build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jan 2010 07:02:14 -0500
From:	Haojian Zhuang <haojian.zhuang@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: linux-next: mfd tree build failure

On Mon, Jan 11, 2010 at 5:51 AM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> On Mon, Jan 11, 2010 at 04:02:32PM +1100, Stephen Rothwell wrote:
>> Hi Sam,
>
>> Today's linux-next build (x86_64_allmodconfig, gcc 4.4.0, binutils
>> 2.19.1) failed like this:
>
>> ERROR: "max8925_set_bits" [drivers/video/backlight/max8925_bl.ko] undefined!
>> ERROR: "max8925_reg_write" [drivers/video/backlight/max8925_bl.ko] undefined!
>> ERROR: "max8925_reg_read" [drivers/video/backlight/max8925_bl.ko] undefined!
>> ERROR: "max8925_set_bits" [drivers/regulator/max8925.ko] undefined!
>> ERROR: "max8925_reg_read" [drivers/regulator/max8925.ko] undefined!
>
>> I am not sure what caused this, so I have used the version of the mfd
>> tree from next-20100108 for today.
>
> CCing in Haojian who did the driver.  I've not looked but I'd guess that
> the issue is missing EXPORT_SYMBOL{,_GPL}s on the symbols above.
>

I'm sorry on inconvience. Now I attache the fix.

Samuel,
Could you help to review and merge this patch?

It's not caused by EXPORT_SYMBOL{,_GPL}. If I build in max8925 mfd
driver, issue is resolved.
Regulator subsystem could only be built in. And 8925 regulator driver
calls i2c operations that is defined in mfd driver. If 8925 regulator
is built it and mfd 8925 is built as module, it will cause linking
error.

Thanks
Haojian

View attachment "0001-mfd-set-max8925-as-built-in.patch" of type "text/x-patch" (883 bytes)