linux-kernel - Re: [PATCH] tpm_infineon: Fix suspend/resume handler for pnp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B4B1764.2060005@sirrix.com>
Date:	Mon, 11 Jan 2010 13:19:48 +0100
From:	Marcel Selhorst <m.selhorst@...rix.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Debora Velarde <debora@...ux.vnet.ibm.com>,
	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tpm_infineon: Fix suspend/resume handler for pnp_driver

Hi,

> I guess it might be tpm_infineon can't suspend/resume properly. However,
> with it, I don't know what happen actually. (it might be, tpm can't
> verify the security issue on suspend/resume process? or can't wakeup
> from tpm? or spend power?  or other?)

On suspend, the TPM framework sends a command "TPM_SaveState" to the chip to
inform it about the upcoming suspend. Therefore it is necessary to have the
function tpm_pm_suspend called (either directly or via pnp). On resume, the
state will automatically be restored by the TPM.

The patch looks good to me, but I haven't had a chance to test it, yet.
As soon as I did, I'll get back to you.

Thanks,
Marcel Selhorst
-- 
Sirrix AG security technologies -- http://www.sirrix.com
Dipl.-Ing. Marcel Selhorst  eMail: m.selhorst@...rix.com
Tel: +49 (234) 610071-126   Fax: +49 (234) 610071-526
Tel: +49 (681)  95986-126   Fax: +49 (681)  95986-526
Get my public key from keyserver, KeyId: 0x7C9821CC
Fingerprint 4138 E617 E62E 79D3 E663 BE5A 14E7 1CD8 7C98 21CC

Vorstand: Ammar Alkassar (Vors.), Christian Stueble
Vorsitzender des Aufsichtsrates: Prof. Dr. Kai Rannenberg
Sitz der Gesellschaft: Homburg/Saar, HRB 3857 Amtsgericht Saarbruecken

This message may contain confidential and/or privileged information.
If you are not the addressee, you must not use, copy, disclose or
take any action based on this message or any information herein.
If you have received this message in error, please advise the sender
immediately by reply e-mail and delete this message.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/