linux-kernel - Re: [PATCH 5/7] Input: wacom - Convert remaining ids, part two

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jan 2010 23:24:48 +0100
From:	Bastian Blank <waldi@...ian.org>
To:	Ping Cheng <pingc@...om.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jason Childs <oblivian@...rs.sourceforge.net>
Subject: Re: [PATCH 5/7] Input: wacom - Convert remaining ids, part two

Please fix your MUA, it should break lines to below 80 characters.

On Mon, Jan 11, 2010 at 01:22:31PM -0800, Ping Cheng wrote:
> Can we only move the struct wacom_features definition to wacom_sys.c
> and leave the device specific wacom_features in wacom_wac.c?

The driver is so small. I don't see any reason to split that at all.

>                                                               Also
> leave the actual wacom_ids [] in wacom_wac.c as well since they are
> wacom specific stuff.

No, this are USB id mappings, Linux specific ones.

>                        We'd like to keep wacom specific stuff in
> wacom_wac.c/h, which hopefully can be shared among kernel releases.

The two parts are not properly seperated, none of them can stand on its
own. How exactly do you want to do that?

> BTW, the testing, led by Jason, got very positive feedbacks. There is
> no crash reported with your patch applied.

Why should there be any crashs? It is a simple restructuring.

While we are at it, why does this driver need this amount of hardcoding
of the values in the kernel anyway?

Bastian

-- 
Schshschshchsch.
		-- The Gorn, "Arena", stardate 3046.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/