linux-kernel - Re: [PATCH net-2.6 alt.3] af_packet: Don't use skb after dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100111224817.GB3369@del.dom.local>
Date:	Mon, 11 Jan 2010 23:48:17 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Michael Breuer <mbreuer@...jas.com>
Cc:	David Miller <davem@...emloft.net>, shemminger@...tta.com,
	akpm@...ux-foundation.org, flyboy@...il.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6 alt.3] af_packet: Don't use skb after
 dev_queue_xmit()

On Mon, Jan 11, 2010 at 05:30:45PM -0500, Michael Breuer wrote:
> On 1/11/2010 3:04 AM, Jarek Poplawski wrote:
...
> >---------------->  (alternative 3)
> >
> >Subject: af_packet: Don't use skb after dev_queue_xmit()
> >
> >tpacket_snd() can change and kfree an skb after dev_queue_xmit(),
> >which is illegal.
> >
> >With debugging by: Stephen Hemminger<shemminger@...tta.com>
> >
> >Reported-by: Michael Breuer<mbreuer@...jas.com>
> >Signed-off-by: Jarek Poplawski<jarkao2@...il.com>
> >
> >Cc: Stephen Hemminger<shemminger@...tta.com>
> >---
> >
> >  net/packet/af_packet.c |   19 ++++++++++++++-----
> >  1 files changed, 14 insertions(+), 5 deletions(-)
...
> Tested by: Michael Breuer
> 
> Note: This patch is delivering better ethernet throughput (15-20%)
> and no  than the previous two patches. I'm also no longer seeing
> dropped RX packets. Good work!

David, if this patch is acceptable now, please add:

With help from: David S. Miller <davem@...emloft.net>

Tested-by: Michael Breuer<mbreuer@...jas.com>

Thanks everybody,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/