linux-kernel - Re: [PATCH v2 -mmotm-2010-01-06-14-34] check high watermark after shrink zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B4A9F12.8020200@redhat.com>
Date:	Sun, 10 Jan 2010 22:46:26 -0500
From:	Rik van Riel <riel@...hat.com>
To:	Minchan Kim <minchan.kim@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Mel Gorman <mel@....ul.ie>, linux-mm <linux-mm@...ck.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Wu Fengguang <fengguang.wu@...el.com>
Subject: Re: [PATCH v2 -mmotm-2010-01-06-14-34] check high watermark after
 shrink zone

On 01/10/2010 06:48 PM, Minchan Kim wrote:
>
>
>   * V2
>    * Add reviewed-by singed-off (Thanks Kosaki, Wu)
>    * Fix typo of changelog
>
> == CUT HERE ==
>
> Kswapd check that zone have enough free by zone_water_mark.
> If any zone doesn't have enough page, it set all_zones_ok to zero.
> !all_zone_ok makes kswapd retry not sleeping.
>
> I think the watermark check before shrink zone is pointless.
> Kswapd try to shrink zone then the check is meaninful.
>
> This patch move the check after shrink zone.
>
> Signed-off-by: Minchan Kim<minchan.kim@...il.com>
> Reviewed-by: KOSAKI Motohiro<kosaki.motohiro@...fujitsu.com>
> Reviewed-by: Wu Fengguang<fengguang.wu@...el.com>
> CC: Mel Gorman<mel@....ul.ie>
> CC: Rik van Riel<riel@...hat.com>

Acked-by: Rik van Riel <riel@...hat.com>

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/