linux-kernel - [PATCH] dma: make Open Firmware device id constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4B4C2BB2.5050308@freemail.hu>
Date:	Tue, 12 Jan 2010 08:58:42 +0100
From:	Németh Márton <nm127@...email.hu>
To:	Dan Williams <dan.j.williams@...el.com>,
	Maciej Sosnowski <maciej.sosnowski@...el.com>
CC:	LKML <linux-kernel@...r.kernel.org>, Julia Lawall <julia@...u.dk>,
	cocci@...u.dk
Subject: [PATCH] dma: make Open Firmware device id constant

From: Márton Németh <nm127@...email.hu>

The match_table field of the struct of_device_id is constant in <linux/of_platform.h>
so it is worth to make the initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// </smpl>

Signed-off-by: Márton Németh <nm127@...email.hu>
Cc: Julia Lawall <julia@...u.dk>
Cc: cocci@...u.dk
---
diff -u -p a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
--- a/drivers/dma/ppc4xx/adma.c 2010-01-07 19:08:39.000000000 +0100
+++ b/drivers/dma/ppc4xx/adma.c 2010-01-08 14:22:37.000000000 +0100
@@ -4940,7 +4940,7 @@ out_free:
 	return ret;
 }

-static struct of_device_id __devinitdata ppc440spe_adma_of_match[] = {
+static const struct of_device_id ppc440spe_adma_of_match[] __devinitconst = {
 	{ .compatible	= "ibm,dma-440spe", },
 	{ .compatible	= "amcc,xor-accelerator", },
 	{},
diff -u -p a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
--- a/drivers/dma/fsldma.c 2009-12-03 04:51:21.000000000 +0100
+++ b/drivers/dma/fsldma.c 2010-01-08 14:22:49.000000000 +0100
@@ -1274,7 +1274,7 @@ static int of_fsl_dma_remove(struct of_d
 	return 0;
 }

-static struct of_device_id of_fsl_dma_ids[] = {
+static const struct of_device_id of_fsl_dma_ids[] = {
 	{ .compatible = "fsl,eloplus-dma", },
 	{ .compatible = "fsl,elo-dma", },
 	{}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/