linux-kernel - [PATCH] vgaarb: fix trylock behaviour accordingly vga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1263319113-6631-2-git-send-email-tiago.vignatti@nokia.com>
Date:	Tue, 12 Jan 2010 19:58:32 +0200
From:	Tiago Vignatti <tiago.vignatti@...ia.com>
To:	Dave Airlie <airlied@...hat.com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	"Paulo R. Zanoni" <przanoni@...il.com>,
	Henry Zhao <Henry.Zhao@....COM>,
	Andy Getzendanner <james.getzendanner@...dents.olin.edu>,
	Brad Spengler <spender@...ecurity.net>,
	"dri-devel@...ts.sf.net" <dri-devel@...ts.sf.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tiago Vignatti <tiago.vignatti@...ia.com>
Subject: [PATCH] vgaarb: fix trylock behaviour accordingly vga_tryget return value

From: Henry Zhao <Henry.Zhao@....COM>

Signed-off-by: Tiago Vignatti <tiago.vignatti@...ia.com>
---
Henry, can you Signed-off-by there?

 drivers/gpu/vga/vgaarb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
index 2f6cf69..0f5f64d 100644
--- a/drivers/gpu/vga/vgaarb.c
+++ b/drivers/gpu/vga/vgaarb.c
@@ -935,7 +935,7 @@ static ssize_t vga_arb_write(struct file *file, const char __user * buf,
 			goto done;
 		}
 
-		if (vga_tryget(pdev, io_state)) {
+		if (!vga_tryget(pdev, io_state)) {
 			/* Update the client's locks lists... */
 			for (i = 0; i < MAX_USER_CARDS; i++) {
 				if (priv->cards[i].pdev == pdev) {
-- 
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/