| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1263332203-5542-1-git-send-email-cascardo@holoscopio.com> Date: Tue, 12 Jan 2010 19:36:43 -0200 From: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com> To: linux-i2c@...r.kernel.org Cc: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>, "Jean Delvare (PC drivers, core)" <khali@...ux-fr.org>, "Ben Dooks (embedded platforms)" <ben-linux@...ff.org>, linux-kernel@...r.kernel.org Subject: [PATCH] i2c: do not use device name after device_unregister dev_dbg outputs dev_name, which is released with device_unregister. This bug resulted in output like this: [ 7860.470713] i2c Xy2�0: adapter [SMBus I801 adapter at 1880] unregistered The right output would be: [ 60.639233] i2c i2c-0: adapter [SMBus I801 adapter at 1880] unregistered Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com> --- drivers/i2c/i2c-core.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 0ac2f90..d5db0f4 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -843,6 +843,9 @@ int i2c_del_adapter(struct i2c_adapter *adap) adap->dev.parent); #endif + /* device name is gone after device_unregister */ + dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name); + /* clean up the sysfs representation */ init_completion(&adap->dev_released); device_unregister(&adap->dev); @@ -855,8 +858,6 @@ int i2c_del_adapter(struct i2c_adapter *adap) idr_remove(&i2c_adapter_idr, adap->nr); mutex_unlock(&core_lock); - dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name); - /* Clear the device structure in case this adapter is ever going to be added again */ memset(&adap->dev, 0, sizeof(adap->dev)); -- 1.6.5.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists