linux-kernel - Re: [RFC PATCH 1/5] use nr_cpus= to set nr_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c441001121423h612ce0e4j9ff21e083340f00@mail.gmail.com>
Date:	Tue, 12 Jan 2010 14:23:35 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Christoph Lameter <cl@...ux-foundation.org>
Cc:	Suresh Siddha <suresh.b.siddha@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"ananth@...ibm.com" <ananth@...ibm.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/5] use nr_cpus= to set nr_cpu_ids early

On Tue, Jan 12, 2010 at 12:48 PM, Christoph Lameter
<cl@...ux-foundation.org> wrote:
> Trouble is that NR_CPUS is used all over the place. If nr_cpu_ids <
> NR_CPUS at boot then there is a danger of for loops to NR_CPUS going out
> of
> bounds.
>
> CONFIG_NR_CPUS is used for various bitmaps so that seems to be
> okay.

cpumask_var?

>
> drivers/acpi/numa.c:acpi_numa_init probably should use nr_cpu_ids
> instead now.

before prefill_possible_map for x86
before setup_nr_cpu_ids for other platform

nr_cpu_ids = NR_CPUS = CONFIG_NR_CPUS

>
> There is an octeon driver in staging that has some issues with NR_CPUS as
> well.
>

that should be fixed, we should use nr_cpu_ids instead for them.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/