linux-kernel - Re: 2.6.33-rc3 -- INFO: possible recursive locking -- (s_active){++++.+}, at: [<c10d2941>] sysfs_hash_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100112030134.GA17483@discord.disaster>
Date:	Tue, 12 Jan 2010 14:01:34 +1100
From:	Dave Chinner <david@...morbit.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Tejun Heo <tj@...nel.org>, "Rafael J. Wysocki" <rjw@...k.pl>,
	Américo Wang <xiyou.wangcong@...il.com>,
	Miles Lane <miles.lane@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Arjan van de Ven <arjan@...radead.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: 2.6.33-rc3 -- INFO: possible recursive locking --
	(s_active){++++.+}, at: [<c10d2941>] sysfs_hash_and_remove+0x3d/0x4f

On Mon, Jan 11, 2010 at 04:32:31PM -0800, Eric W. Biederman wrote:
> Tejun Heo <tj@...nel.org> writes:
> 
> > On 01/11/2010 11:26 AM, Eric W. Biederman wrote:
> >> From: Eric W. Biederman <ebiederm@...ssion.com>
> >> Date: Sun, 10 Jan 2010 18:13:35 -0800
> >> Subject: [PATCH] sysfs: Add support for lockdep subclasses to s_active
> >> 
> >> We have apparently valid cases where the code for a sysfs attribute
> >> removes other sysfs attributes.  Without support for subclasses
> >> lockdep flags a possible recursive lock problem as it figures
> >> the first sysfs attribute could be attempting to remove itself.
> >> 
> >> By adding support for sysfs subclasses we can teach lockdep to
> >> distinguish between different types of sysfs attributes and not
> >> get confused.
> >> 
> >> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
> >
> > Acked-by: Tejun Heo <tj@...nel.org>
> 
> Now if I can just get a Tested-by  this patch will be all set ;)

Hi Eric,

Is this the same locking problem that this patch fixes?

http://lkml.org/lkml/2010/1/11/26

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/