linux-kernel - Re: [PATCH] hwmon: (smsc47m1) Fix section mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100113114451.3f21ac20@hyperion.delvare>
Date:	Wed, 13 Jan 2010 11:44:51 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Jeff Mahoney <jeffm@...e.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] hwmon: (smsc47m1) Fix section mismatch

Hi Jeff,

On Tue, 12 Jan 2010 19:48:56 -0500, Jeff Mahoney wrote:
> Subject: [patch 1/6] smsc47m1: Fix section mismatch
> References: <20100113004855.550486769@...e.com>
> Content-Disposition: inline; filename=patches.rpmify/smsc47m1-fix-section-mismatch
> 
>  smsc47m1_restore is called from sm_smsc47m1_exit, which is an __exit
>  function, so it can't be __init.
> 
> Signed-off-by: Jeff Mahoney <jeffm@...e.com>
> ---
>  drivers/hwmon/smsc47m1.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/hwmon/smsc47m1.c
> +++ b/drivers/hwmon/smsc47m1.c
> @@ -488,7 +488,7 @@ static int __init smsc47m1_find(unsigned
>  }
>  
>  /* Restore device to its initial state */
> -static void __init smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
> +static void smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
>  {
>  	if ((sio_data->activate & 0x01) == 0) {
>  		superio_enter();
> 

Good catch, thanks for reporting. I do not get any warning about this
one, even though I build the driver as a module and with hotplug
support enabled. I don't get it.

Anyway, patch applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/