linux-kernel - Re: [PATCH] ibmphp : read the length of ebda and map entire ebda region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201001131622.36362.chandru@in.ibm.com>
Date:	Wed, 13 Jan 2010 16:22:35 +0530
From:	Chandru <chandru@...ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, gregkh@...e.de,
	linux-pci@...r.kernel.org, Jesse Barnes <jbarnes@...tuousgeek.org>,
	stable@...nel.org
Subject: Re: [PATCH] ibmphp : read the length of ebda and map entire ebda region

On Wednesday 13 January 2010 06:56:40 Andrew Morton wrote:
> 
> Your email client is performing wordwrapping on the patches.

Sorry for this, I changed the word wrap settings of my client

> 
> All the other ioremap() calls are checked for failure, so this one
> should also be checked, no?

Yes, it needs to be checked. thanks for adding the additional check.

> 
> --- a/drivers/pci/hotplug/ibmphp_ebda.c~ibmphp-read-the-length-of-ebda-and-map-entire-ebda-region-fix
> +++ a/drivers/pci/hotplug/ibmphp_ebda.c
> @@ -261,6 +261,8 @@ int __init ibmphp_access_ebda (void)
>  	debug ("returned ebda segment: %x\n", ebda_seg);
>  	
>  	io_mem = ioremap(ebda_seg<<4, 1);
> +	if (!io_mem)
> +		return -ENOMEM;
>  	ebda_sz = readb(io_mem);
>  	iounmap(io_mem);
>  	debug("ebda size: %d(KiB)\n", ebda_sz);
> _
> 

> 
> A kernel oops is somewhat serious.  Would I be correct in assuming that
> this fix is needed in 2.6.32.x and perhaps earlier kernels?

Yes, I just checked with 2.6.30 kernel and the issue exists over there too. So it applies to all older kernels.

Thanks, 
Chandru


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/