linux-kernel - Re: [PATCH] regulator: Add 'start-up time' to fixed voltage regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B4DB94E.8080602@nokia.com>
Date:	Wed, 13 Jan 2010 14:15:10 +0200
From:	Adrian Hunter <adrian.hunter@...ia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Liam Girdwood <lrg@...mlogic.co.uk>,
	"Quadros Roger (Nokia-D/Helsinki)" <roger.quadros@...ia.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: Add 'start-up time' to fixed voltage regulators

Mark Brown wrote:
> On Wed, Jan 13, 2010 at 01:58:26PM +0200, Adrian Hunter wrote:
> 
>> Add a field to specify a delay for the start-up time of
>> a fixed voltage regulator.
> 
>> Signed-off-by: Adrian Hunter <adrian.hunter@...ia.com>
> 
> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> 
> but...
> 
>> #include <linux/regulator/driver.h>
>> #include <linux/regulator/fixed.h>
>> #include <linux/gpio.h>
>> +#include <linux/delay.h>
> 
> I think your MUA may have eaten the patch - it looks like the leading
> spaces got stripped which is liable to confuse things.
> 

Are you sure?  Looks fines to me.

>> --- a/include/linux/regulator/fixed.h
>> +++ b/include/linux/regulator/fixed.h
>> @@ -25,6 +25,7 @@ struct regulator_init_data;
>>  * @microvolts:		Output voltage of regulator
>>  * @gpio:		GPIO to use for enable control
>>  * 			set to -EINVAL if not used
>> + * @delay:		Start-up time in microseconds
> 
> startup_delay?  Just in case we think of another delay, though I'm
> struggling to think of one right now so I'm not too worried.
> 

I am too lazy to change it unless there is something else too ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/