linux-kernel - Re: [PATCH] perf: make cmd_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <110235132.210191263389315584.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
Date:	Wed, 13 Jan 2010 08:28:35 -0500 (EST)
From:	John Kacur <jkacur@...hat.com>
To:	Wenji Huang <wenji.huang@...cle.com>
Cc:	fweisbec@...il.com, acme@...hat.com, mingo@...e.hu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: make cmd_to_page function compact


----- "Wenji Huang" <wenji.huang@...cle.com> wrote:

> Remove branch for is_perf_command
> 
> Signed-off-by: Wenji Huang <wenji.huang@...cle.com>
> ---
>  tools/perf/builtin-help.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> index 9f810b1..65e2691 100644
> --- a/tools/perf/builtin-help.c
> +++ b/tools/perf/builtin-help.c
> @@ -314,8 +314,6 @@ static const char *cmd_to_page(const char
> *perf_cmd)
>  		return "perf";
>  	else if (!prefixcmp(perf_cmd, "perf"))
>  		return perf_cmd;
> -	else if (is_perf_command(perf_cmd))
> -		return prepend("perf-", perf_cmd);
>  	else
>  		return prepend("perf-", perf_cmd);
>  }
> -- 
> 1.5.6


Thanks, Wenji, I tested your change, and it works find.
Acked-by: John Kacur <jkacur@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/