linux-kernel - Re: [PATCH] tracing, function_graph: simplify test for tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100113145454.GE5036@nowhere>
Date:	Wed, 13 Jan 2010 15:54:56 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing, function_graph: simplify test for tracing

On Wed, Jan 13, 2010 at 07:38:30PM +0800, Lai Jiangshan wrote:
> 
> For function_graph, a calling function is to be traced only when
> it is enabled or it is nested in a enabled function.
> 
> Current code uses TSK_TRACE_FL_GRAPH to test whether it is nested or not.
> read the code, we can get this:
> (trace->depth > 0) <==> (TSK_TRACE_FL_GRAPH is set)
> 
> trace->depth is more explicit to tell that it is nested.
> So we use trace->depth directly and simplify the code.
> 
> No functionality is changed.
> TSK_TRACE_FL_GRAPH is not removed now, it is left for future usage.
> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---


Looks prety good to me. Nice simplification, the less checks we
have in this hot path, the better.

Acked-by: Frederic Weisbecker <fweisbec@...il.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/