linux-kernel - Re: Changelog quality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201001131849.42328.bzolnier@gmail.com>
Date:	Wed, 13 Jan 2010 18:49:42 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Julia Lawall <julia@...u.dk>,
	Németh Márton <nm127@...email.hu>,
	David Vrabel <david.vrabel@....com>, linux-usb@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, cocci@...u.dk
Subject: Re: Changelog quality

On Wednesday 13 January 2010 06:29:07 pm Alan Stern wrote:
> On Wed, 13 Jan 2010, Stefan Richter wrote:
> 
> > If it was by mistake, inclusion of the find-and-replace script into the
> > patch posting *after the --- delimiter* might have increased the chance
> > that a patch reviewer becomes aware of a possible error source
> > (inadequate match patterns...).  So that could be useful during review
> > before commit, but not so much if the change is revisited some time
> > after commit.
> 
> Somewhat tangentially, it's worth mentioning that the comments
> appearing after the "---" delimiter exist only in the original patch
> submissions, not in the final commits.  Hence they are not available to
> anyone reviewing the changes after acceptance.
> 
> It would be nice if there was a way to link automatically a git commit
> to an archived copy of the email message in which it was originally 
> submitted.

AFAIK x86 folks are using "LKML-Reference:" tag with the message ID for
exactly that purpose (just do 'git log arch/x86' to find such commits).

BTW Personally I see nothing wrong with too verbose commit changelogs,
too sparse changelogs are a much bigger annoyance..

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/